>>>> I overlooked the elog() call and "own implementation of >>>> get_func_name()". Will fix. >>> >>> Attached is a trivial patch to fix that. I am going to push it if >>> there's no objection. >>> >>> Best regards, >>> -- >>> Tatsuo Ishii >>> SRA OSS K.K. >>> English: http://www.sraoss.co.jp/index_en/ >>> Japanese:http://www.sraoss.co.jp >>> <v1-0001-Use-ereport-rather-than-elog-in-WinCheckAndInitia.patch> >> >> >> I just take a quick look at the patch, a tiny comment is: >> >> ``` >> + char *funcname = get_func_name(fcinfo->flinfo->fn_oid); >> ``` >> >> This can be a “const char *”. > > Thanks for the review. In addition to the point, I added an assertion > which is called by all other window function API. Also added check to > the return value of get_func_name() because it could return NULL. V2 > patch attached.
V2 patch pushed. Thanks. Best regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
