On Mon, Oct 20, 2025 at 5:29 PM Hayato Kuroda (Fujitsu)
<[email protected]> wrote:
>
> > Here is the latest patch set which addressed Shveta[1], Amit[2], Chao[3][4],
> > Dilip[5], Sawada-San's[6] comments.
>
> I found the patch could not pass the sanity check, because 0001 missed a
> comma.
> Also, there was a duplicated entry for `REFRESH SEQUENCES`.
>
> Attached set fixed the issue.
>
Some minor comments on 0001:
>
+
+# This tests that sequences are synced correctly to the subscriber
>
Is this comment okay for 0001? How about: This tests that sequences
are registered to be synced to the subscriber?
+# Avoid checkpoint during the test, otherwise, extra values will be fetched for
+# the sequences which will cause the test to fail randomly.
+$node_publisher->init(allows_streaming => 'logical');
+$node_publisher->append_conf('postgresql.conf', 'checkpoint_timeout = 1h');
Do we need to set this additional GUC for 0001? I understand it could
be required for 0002 though.
--
With Regards,
Amit Kapila.
