Hi, On Tue, 21 Oct 2025 at 15:19, Jelte Fennema-Nio <[email protected]> wrote: > > At PGConf.dev 2025 one thing that came up in the "Scaling PostgreSQL > Development" unconference session is that new hackers don't know all the > details of our development flow by heart yet. Of course it's documented > on the wiki, but even if they find the relevant wiki pages they often > still miss/forget things. One of the things they often forget is > formatting their code. The consensus at that session was that it was > probably worth adding a CI task for this to nudge newcomers to indent > their code. > > We're not too worried about this new requirement scaring away newcomers, > since autoformatting has become fairly commonplace in open source > development. Also committers can of course still choose to format the > patch themselves before committing if the formatting is failing. > > This might also help reduce the number of unindented commits that > committers push, which require a follow up "fix indent" commit to make > the koel buildfarm animal happy again.
Thank you for working on this! I think this is a great idea. What do you think about moving this inside of another CI task instead of creating a new one? I think that creating a new VM and cloning Postgres into it would be unnecessary but I could not decide which task would be a good choice for this. Do you think that this task should format perl files as well? Other than the things I mentioned above, the code looks good to me. -- Regards, Nazir Bilal Yavuz Microsoft
