On Thu, Aug 30, 2018 at 10:39:26AM -0400, Tom Lane wrote: > I rather suspect that this hasn't been tested on anything but Intel > hardware, which is famously misalignment-tolerant. The lack of any > apparent regression test infrastructure for it isn't leaving a warm > feeling about how much the buildfarm is testing it. > > (The right fix, of course, is to malloc the work buffer rather than > put it on the stack.)
pg_upgrade/file.c is careful about that (5afcd2a), and has a comment on the matter, as does pg_standby.c. Now, grepping around for "BLCKSZ]", some garbage may have accumulated? - entrySplitPage in ginentrypage.c - rewind_copy_file_range in file.c - _hash_alloc_buckets in hashpage.c - pg_prewarm.c - blinsert.c - pg_waldump.c - logtape.c -- Michael
signature.asc
Description: PGP signature
