Hi, On 2025-11-07 19:03:46 -0500, Tom Lane wrote: > Thomas Munro <[email protected]> writes: > > Alexander did some extensive testing and we stared at the codegen on a > > lot of architectures to confirm that this prevents the reordering. > > Pushed and back-patched like that. > > You're a brave man to be pushing this into the last-ever release > of v13 with all of 12 hours remaining till code freeze. I don't > mind so much for the newer branches, but I'm feeling nervous > about the risk/reward ratio for v13.
The patch doesn't do anything complicated, it just adds a compiler barrier to the read/write barriers. As both the compiler barrier and read/write barrier code is old I don't see a whole lot of potential for problems here. If this were changing inline assembly or such, it'd be a different story... Greetings, Andres Freund
