Daniel Gustafsson <[email protected]> writes:
> It's still not clear to ne that we should make pg_getaddr_info() mimic the API
> of getaddrinfo since it's not a thin wrapper over getaddrinfo. The
> alternative
> option would be to return EAI_FAIL on a null hint and force the caller to
> provide an AF_UNSPEC if that is what is indeed asked for.
We already reject null hints (by crashing), and have done for decades.
I don't think there's anything very wrong with the current code, and I
don't really see that the proposed patch is an improvement. If
anything, I'd just add a comment to pg_getaddrinfo_all saying that
unlike bare getaddrinfo, we require a valid hintp.
regards, tom lane
