> On 13 Nov 2025, at 09:13, Álvaro Herrera <[email protected]> wrote: > On 2025-Nov-13, Zhijie Hou (Fujitsu) wrote:
>> During testing of libpq, I noticed several error messages not processed by >> libpq_gettext, resulting in their exclusion from *.pot files. The attached >> patch >> wraps these messages. Thanks for the report! > Yeah, this roughly makes sense. I think the documentation for errctx in > async_ctx needs to be updated though, because currently it says "it'll > be translated for you" but this patch makes it the other way around (it > must come translated). +1 > Alternatively, we could mark the strings with gettext_noop(), which only > adds the messages to the catalog without translating them; so the > responsibility of translating them would remain where it is today. This > might be easier. I was pondering that since auth error messages in backend libpq does this, but since we don't use gettext_noop anywhere else in frontend libpq today it makes sense to go with libpq_gettext and update the docs instead. Unless you, who has more translation/nls insights than me, feel strongly about gettext_noop I'll go ahead with the current patch. -- Daniel Gustafsson
