On Thu, Nov 20, 2025 at 12:23:25PM +1300, David Rowley wrote: > On Thu, 20 Nov 2025 at 10:58, Bruce Momjian <[email protected]> wrote: > > I think you are right. Attached is the difference between the output > > for 16 & 17. Let me do some more research and run all the versions > > again and report back, thanks. > > Maybe you'd be better with git ls-files if you only want just what's > in the repo. Something like: > > for b in "REL8_0_0" "REL8_1_0" "REL8_2_0" "REL8_3_0" "REL8_4_0" > "REL9_0_0" "REL9_1_0" "REL9_2_0" "REL9_3_0" "REL9_4_0" "REL9_5_0" > "REL9_6_0" "REL_10_0" "REL_11_0" "REL_12_0" "REL_13_0" "REL_14_0" > "REL_15_0" "REL_16_0" "REL_17_0" "REL_18_0" "master"; do git checkout > -f $b > /dev/null 2>&1 && echo -n "$b " && git ls-files -- '*.[chyl]' > | xargs cat | wc -l; done
Yes, I like "git ls-files" since it gives the same count as Tom's version but doesn't modify the git tree. The old script pre-dates git and I didn't consider "git" could give us a better solution. Attached is the applied patch. And here are the updated line counts. I went all the way back to 7.1 which is the last stasble git branch. --------------------------------------------------------------------------- version | reldate | months | changes | C lines | C changes | % C change ----------+------------+--------+---------+---------+-----------+------------ 4.2 | 1994-03-17 | | | 250872 | | 1.0 | 1995-09-05 | 18 | | 172470 | -78402 | -31 1.01 | 1996-02-23 | 6 | | 179463 | 6993 | 4 1.09 | 1996-11-04 | 8 | | 178976 | -487 | 0 6.0 | 1997-01-29 | 3 | | 189399 | 10423 | 5 6.1 | 1997-06-08 | 4 | | 200709 | 11310 | 5 6.2 | 1997-10-02 | 4 | | 225848 | 25139 | 12 6.3 | 1998-03-01 | 5 | | 260809 | 34961 | 15 6.4 | 1998-10-30 | 8 | | 297918 | 37109 | 14 6.5 | 1999-06-09 | 7 | | 331278 | 33360 | 11 7.0 | 2000-05-08 | 11 | | 383270 | 51992 | 15 7.1 | 2001-04-13 | 11 | | 380642 | -2628 | 0 7.2 | 2002-02-04 | 10 | 250 | 425898 | 45256 | 11 7.3 | 2002-11-27 | 10 | 305 | 439816 | 13918 | 3 7.4 | 2003-11-17 | 12 | 263 | 522371 | 82555 | 18 8.0 | 2005-01-19 | 14 | 230 | 586127 | 63756 | 12 8.1 | 2005-11-08 | 10 | 174 | 625253 | 39126 | 6 8.2 | 2006-12-05 | 13 | 215 | 684726 | 59473 | 9 8.3 | 2008-02-04 | 14 | 214 | 765100 | 80374 | 11 8.4 | 2009-07-01 | 17 | 314 | 817849 | 52749 | 6 9.0 | 2010-09-20 | 15 | 237 | 870790 | 52941 | 6 9.1 | 2011-09-12 | 12 | 203 | 932936 | 62146 | 7 9.2 | 2012-09-10 | 12 | 238 | 987460 | 54524 | 5 9.3 | 2013-09-09 | 12 | 177 | 1040813 | 53353 | 5 9.4 | 2014-12-18 | 15 | 211 | 1096707 | 55894 | 5 9.5 | 2016-01-07 | 13 | 193 | 1167110 | 70403 | 6 9.6 | 2016-09-29 | 9 | 214 | 1219720 | 52610 | 4 10 | 2017-10-05 | 12 | 189 | 1316447 | 96727 | 7 11 | 2018-10-18 | 12 | 170 | 1369590 | 53143 | 4 12 | 2019-10-03 | 11 | 180 | 1423215 | 53625 | 3 13 | 2020-09-24 | 12 | 178 | 1473738 | 50523 | 3 14 | 2021-09-30 | 12 | 220 | 1558178 | 84440 | 5 15 | 2022-10-13 | 12 | 184 | 1587763 | 29585 | 1 16 | 2023-09-14 | 11 | 206 | 1608031 | 20268 | 1 17 | 2024-09-26 | 12 | 182 | 1673116 | 65085 | 4 18 | 2025-09-25 | 12 | 210 | 1750814 | 77698 | 4 Averages | | 11 | 215 | | | 5.60 -- Bruce Momjian <[email protected]> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.
diff --git a/src/tools/codelines b/src/tools/codelines index 11e86accf27..93ad571acf9 100755 --- a/src/tools/codelines +++ b/src/tools/codelines @@ -3,5 +3,5 @@ # src/tools/codelines # This script is used to compute the total number of "C" lines in the release -# This should be run from the top of the Git tree after a 'make distclean' -find . -name '*.[chyl]' | xargs cat| wc -l +# This should be run from the top of the Git tree. +git ls-files -- '*.[chyl]' | xargs cat | wc -l
