On Thu, 20 Nov 2025 at 17:36, Nathan Bossart <[email protected]> wrote:
> I took a quick look at 0001. > > +#ifdef _MSC_VER > +#include <intrin.h> > +#else > #include <arm_acle.h> > unsigned int crc; > > I think you can remove this since we unconditionally do the runtime check > for MSVC. In any case, the missing #endif seems likely to cause > problems. > > --- a/src/port/pg_crc32c_armv8.c > +++ b/src/port/pg_crc32c_armv8.c > @@ -14,7 +14,9 @@ > */ > #include "c.h" > > +#ifndef _MSC_VER > #include <arm_acle.h> > +#endif > > Hm. Doesn't MSVC require intrin.h? > > -- > nathan > I posted this as a bug with Microsoft https://developercommunity.visualstudio.com/t/MSVCs-_InterlockedCompareExchange-doe/11004239 Dave
