On Fri, 21 Nov 2025 at 11:30, Amit Kapila <[email protected]> wrote: > > On Fri, Nov 21, 2025 at 11:00 AM shveta malik <[email protected]> wrote: > > > > A few comments on 001: > > > > 1) > > + slots, but may (if leftover from a promotedstandby) contain a > > timestamp. > > promotedstandby --> promoted standby > > > > 2) > > + s.slotsync_skip_count, > > + s.last_slotsync_skip_at, > > > > Shall we rename last_slotsync_skip_at to slotsync_last_skip_at. That > > way all slotsync related stats columns will have same prefix. > > > > Sounds reasonable especially when the doc explains that this is the > time at which last slot synchronization was skipped. > Made the change in the latest patch.
> BTW, can we split the patch into two? First for slot sync skip stats, > and the second one for SlotSyncSkipReason? It would be easier to > review and commit that way. > I have split the patch into two: 0001 - Adds columns slotsync_skip_count and slotsync_last_skip_at in pg_stats_replication_slots view 0002 - Adds column slotsync_skip_reason in pg_replication_slots view Please find the latest patch in [1]. [1]: https://www.postgresql.org/message-id/CANhcyEUiY4ENuoi7kZSsLJFLn6yA_-oPCKrek%3DBaMfFfY3%3DP1w%40mail.gmail.com Thanks, Shlok Kyal
