Hi Shlok. I checked the latest v28-0004 "EXCEPT (col-list)" patch. I have no code review comments, but I do have one syntax question.
====== The result of the current patch proposed syntax is like: CREATE PUBLICATION pubname FOR TABLE tabname EXCEPT (col1, col2, col3) ALTER PUBLICATION pubname ADD TABLE tabname EXCEPT (col1, col2, col3) ~~ In the previous patch v28-0003 (FOR ALL TABLES EXCEPT [TABLE]), I thought the optional noise-word TABLE did not have any user benefit because TABLE was already obvious. OTOH, here in patch v28-0004, it might be helpful to have an *optional* [COLUMN] part. e.g., I felt "EXCEPT [COLUMN]" would improve the readability of these commands. Compare: CREATE PUBLICATION pubname FOR TABLE tabname EXCEPT (col1, col2, col3) CREATE PUBLICATION pubname FOR TABLE tabname EXCEPT COLUMN (col1, col2, col3) Compare: ALTER PUBLICATION pubname ADD TABLE tabname EXCEPT (col1, col2, col3) ALTER PUBLICATION pubname ADD TABLE tabname EXCEPT COLUMN (col1, col2, col3) This is similar to the optional "[COLUMN]" keyword used here [1]. Thoughts? ====== [1] https://www.postgresql.org/docs/devel/sql-altertable.html Kind Regards, Peter Smith. Fujitsu Australia
