Re: Some optimizations for COALESCE expressions during constant folding

[Dagfinn Ilmari Mannsåker]

Richard Guo <guofengli...@gmail.com> writes:

> +                                     ListCell   *lc;
> +
> +                                     foreach(lc, coalesceexpr->args)
> +                                     {
> +                                             Node       *coalescearg = (Node 
> *) lfirst(lc);

I have no comment on the rest of the patch, but this could be simplifed
using the foreach_ptr macro:

        foreach_ptr(Node, coalescearg, coalesceexpr->args)
        {

- ilmari