On Wednesday, November 26, 2025 2:29 PM Shlok Kyal <[email protected]> wrote: > I have also addressed the remaining comments and attached the updated > patch.
Thanks for updating the patch, I have few comments: 1. +/* + * Map a SlotSyncSkipReason enum to a human-readable string + */ +static char * +GetSlotSyncSkipReasonName(SlotSyncSkipReason reason) Shall we add a static array to map the Enum value to the reason name instead of adding the following function ? 2. + <literal>remote_behind</literal> means that the slot is ahead of the + corresponding failover slot on the primary. I think the current naming and doc is not easy for user to understand. So, I suggest mentioning the explicit reason of this skip, e.g., the required WALs and rows are removed or at the risk of removal. We can rename this reason to "wal_or_rows_removed" and make the document similar to the content in logicaldecoding.sgml. Best Regards, Hou zj
