pt., 28 lis 2025 o 16:17 Nazir Bilal Yavuz <[email protected]> napisał(a): > > Hi, > > On Fri, 28 Nov 2025 at 18:05, Nazir Bilal Yavuz <[email protected]> wrote: > > > > On Fri, 28 Nov 2025 at 17:03, Miłosz Bieniek <[email protected]> > > wrote: > > > > > > pt., 28 lis 2025 o 12:53 Peter Eisentraut <[email protected]> > > > napisał(a): > > > > > > > > On 27.11.25 10:28, Miłosz Bieniek wrote: > > > > > While reviewing a patch I noticed that we have a `make -s > > > > > headerscheck` > > > > > but there is no equivalent in meson. > > > > > I prepared a small patch that adds `headerscheck` and `cpluspluscheck` > > > > > targets. > > > > > > > > This would be good to have, but I don't think your patch works. It > > > > seems you need to add the srcdir and builddir command-line arguments to > > > > the invocations. > > > > > > > > > > I think you are right. I added srcdir and builddir arguments. > > > > The headerscheck script pulls some information from Makefile.global > > after the configure [1] but meson does not generate a full version of > > Makefile.global [2], so it does not have the required information to > > check perl and python headers. If you run 'meson compile > > headerscheck', you get errors like: > > Sorry, I clicked send early. > > Two solutions came to my mind but I am not sure which one is better: > > 1) We can add missing information to the generated Makefile.global in > the meson.build. > > 2) We can send required information as arguments to the headerscheck script. > > Any thoughts or suggestions?
Thank you for the detailed response. I initially thought the errors with `#include <Python.h>` and `#include <EXTREN.h>` were only an issue with my local setup. If I understand correctly, your first proposal would address this problem without requiring integration with the headerscheck script, which in my opinion would be a cleaner solution. However, I would definitely like to hear what others think as well.
