On Fri, Nov 28, 2025 at 01:05:55PM +0900, Michael Paquier wrote: > On Thu, Nov 27, 2025 at 12:00:30PM +0300, Kirill Reshke wrote: >> Shouldnt `SEQ_LOG_VALS` be moved to sequnce_xlog.c ? > > I am not sure to follow this one. This controls the frequency of the > records inserted, which has nothing to do with the redo path. > >> Also, while on it, maybe it is worth to rename xl_seq_rec struct to >> something. It will be more convenient to make a name in sync with the >> XLOG_SEQ_LOG WAL record (like we do in heapxlog). Maybe struct >> xl_seq_log ? > > I am not sure to see the value in a rename for the scope of this > patch, sequence.h already published them.
On a second look, I cannot get behind these two arguments. So I have applied the patch as-is, after fixing a comment. Now onto some more interesting work.. -- Michael
signature.asc
Description: PGP signature
