On Mon, Dec 1, 2025 at 12:32 PM Michael Paquier <[email protected]> wrote: > > On Fri, Nov 28, 2025 at 09:46:43AM +0530, Amul Sul wrote: > > I have attached patch 0002 that renames it. I also updated patch 0001 > > to accommodate Amit's comment suggestions. > > Thanks, applied this one after more tweaks. Regarding 0002, just > doing a renaming makes me a bit uncomfortable after a second look. > Another way to look at the problem while being consistent would be to > convert date2timestamp_no_overflow() to use soft error reports, > requiring its caller in selfuncs.c to use an error context node. I > cannot get really excited at the end just for the sake of the planner > stats. >
Understood. Thanks for committing the patch. > There were two more functions that btree_gin.c is pointing at that > could to the switch: timestamp->timestamptz and its opposite. This > also shaves some code, which is nice. Please see the attached. Yes, the patch looks good to me. Regards, Amul
