On Tue, Nov 25, 2025 at 8:30 AM jian he <[email protected]> wrote: > > On Mon, Nov 24, 2025 at 11:38 AM Amul Sul <[email protected]> wrote: > > > > [...] > +static inline float8 > +float8_div_safe(const float8 val1, const float8 val2, struct Node *escontext) > > but we can change float8_div to: > > static inline float8 > float8_div(const float8 val1, const float8 val2) > { > return float8_div_safe(val1, val2, NULL); > } > I am worried that entering another function would cause a minor performance > degradation. And since these simple functions are so simple, keeping them > separated should not be a big problem. also I placed float8_div, > float8_div_safe together.
Since you declared float8_div_safe() as static inline, I believe it wouldn't have any performance degradation since most compilers optimize it. Also, I suggest you pass the ErrorSafeContext to float_overflow_error(), float_underflow_error(), and float_zero_divide_error() so that you can avoid duplicating error messages. Regards, Amul
