On 2018-Sep-05, Tom Lane wrote:
> Alvaro Herrera <alvhe...@2ndquadrant.com> writes:
> > That said, I haven't heard of anyone using these functions in code yet,
> > so if we change it in 11 or 12 nobody is going to complain.
>
> ... and that's pretty much my feeling. It seems really unlikely that
> anyone's using named-argument notation for pg_get_object_address, and
> even if they are, it wouldn't be very painful to change, or just not
> use the notation if they need cross-branch compatibility. I think it's
> more useful in the long run to make the names consistent.
>
> Will go take care of it.
Agreed, thanks. If you haven't touched the docs yet, here's the change
-- 9.5/9.6/10 need a slight adjustment from 11/master.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index bb794e044f..853e5fee7c 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -17701,7 +17701,7 @@ SELECT collation for ('foo' COLLATE "de_DE");
</row>
<row>
<entry><literal><function>pg_identify_object_as_address(<parameter>catalog_id</parameter>
<type>oid</type>, <parameter>object_id</parameter> <type>oid</type>,
<parameter>object_sub_id</parameter>
<type>integer</type>)</function></literal></entry>
- <entry><parameter>type</parameter> <type>text</type>,
<parameter>name</parameter> <type>text[]</type>, <parameter>args</parameter>
<type>text[]</type></entry>
+ <entry><parameter>type</parameter> <type>text</type>,
<parameter>object_names</parameter> <type>text[]</type>,
<parameter>object_args</parameter> <type>text[]</type></entry>
<entry>get external representation of a database object's
address</entry>
</row>
<row>
@@ -17745,7 +17745,8 @@ SELECT collation for ('foo' COLLATE "de_DE");
information is independent of the current server, that is, it could be used
to identify an identically named object in another server.
<parameter>type</parameter> identifies the type of database object;
- <parameter>name</parameter> and <parameter>args</parameter> are text arrays
that together
+ <parameter>object_names</parameter> and <parameter>object_args</parameter>
+ are text arrays that together
form a reference to the object. These three columns can be passed to
<function>pg_get_object_address</function> to obtain the internal address
of the object.
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 5e95325250..7f903fa2d1 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -17016,7 +17016,7 @@ SELECT collation for ('foo' COLLATE "de_DE");
</row>
<row>
<entry><literal><function>pg_identify_object_as_address(<parameter>catalog_id</parameter>
<type>oid</>, <parameter>object_id</parameter> <type>oid</>,
<parameter>object_sub_id</parameter>
<type>integer</>)</function></literal></entry>
- <entry><parameter>type</> <type>text</>, <parameter>name</>
<type>text[]</>, <parameter>args</> <type>text[]</></entry>
+ <entry><parameter>type</> <type>text</>, <parameter>object_names</>
<type>text[]</>, <parameter>object_args</> <type>text[]</></entry>
<entry>get external representation of a database object's
address</entry>
</row>
<row>
@@ -17060,7 +17060,7 @@ SELECT collation for ('foo' COLLATE "de_DE");
information is independent of the current server, that is, it could be used
to identify an identically named object in another server.
<parameter>type</> identifies the type of database object;
- <parameter>name</> and <parameter>args</> are text arrays that together
+ <parameter>object_names</> and <parameter>object_args</> are text arrays
that together
form a reference to the object. These three columns can be passed to
<function>pg_get_object_address</> to obtain the internal address
of the object.
