Hi, On Thu, 4 Dec 2025 at 14:21, Álvaro Herrera <[email protected]> wrote: > > On 2025-Dec-04, Chao Li wrote: > > > The motivation is that CF’s CI currently fails on shadow-variable warnings. > > If you touch a file like a.c, and that file already has a legacy shadowing > > issue, CI will still fail your patch even if your changes are correct. Then > > you’re forced to fix unrelated shadow-variable problems just to get a clean > > CI run. I’ve run into this myself, and it’s disruptive for both patch > > authors and reviewers. > > Hmm, maybe that should be turned off. It sounds seriously unhelpful.
To test that I created this CI run [1], which edits the brin.c file. That file has a legacy shadowing issue but the CI did not fail. Could you please show an example CI run? [1] https://cirrus-ci.com/build/5444936843132928 -- Regards, Nazir Bilal Yavuz Microsoft
