Hi Hackers,
I noticed that makeRangeConstructors (in commands/typecmds.c) says:
> We actually define 4 functions, with 0 through 3 arguments.
But that hasn't been true since 2011 (df73584431). We only have 2-arg
and 3-arg functions. Here is a quick patch to update the comment.
Yours,
--
Paul ~{:-)
[email protected]
From 8705883adedd73ae5818bf2e8011be775d28a1d8 Mon Sep 17 00:00:00 2001
From: "Paul A. Jungwirth" <[email protected]>
Date: Tue, 2 Dec 2025 20:35:00 -0800
Subject: [PATCH v1] Fix out-of-date comment on makeRangeConstructors
We did define 4 functions in 4429f6a9e3, but in df73584431e7 we got rid of the
0- and 1-arg versions.
Author: Paul A. Jungwirth <[email protected]>
---
src/backend/commands/typecmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/commands/typecmds.c b/src/backend/commands/typecmds.c
index 47d5047fe8b..d48b93ee99e 100644
--- a/src/backend/commands/typecmds.c
+++ b/src/backend/commands/typecmds.c
@@ -1767,7 +1767,7 @@ DefineRange(ParseState *pstate, CreateRangeStmt *stmt)
* impossible to define a polymorphic constructor; we have to generate new
* constructor functions explicitly for each range type.
*
- * We actually define 4 functions, with 0 through 3 arguments. This is just
+ * We actually define 2 functions, with 2 through 3 arguments. This is just
* to offer more convenience for the user.
*/
static void
--
2.47.3
