> On Dec 6, 2025, at 07:14, Tom Lane <[email protected]> wrote:
>
> v5, rebased over a couple of recent patches. No substantive changes.
>
> I'd kind of like to get this pushed soon, because it keeps getting
> sideswiped ... does anyone have further comments?
Actually I traced v4 again this week. I tried to find out something to comment,
but ended up I didn’t find anything significant.
My only nit commit is still about the hard-coded 12:
```
+ case TIMETZOID:
+ /* pass-by-reference */
+ oldcontext =
MemoryContextSwitchTo(outcontext);
+ v->val.datetime.value =
datumCopy(v->val.datetime.value,
+
false, 12);
```
I commented this before and you explained. But I still think it may deserve a
comment for why 12 is here, otherwise future reader may also get the same
confusion as when I first time read this code.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
