> On Dec 11, 2025, at 09:57, Euler Taveira <[email protected]> wrote:
>
>
>> In the “if” and “else” clauses, there are duplicate code to valid log
>> levels. We should refactor the code to avoid the duplication. For
>> example, pull up “loglevel” to the “for” loop level, then we can valid
>> it after the “if-else”.
>>
>
> The for loop is duplicate but if you create a separate function for it but the
> result is:
>
> src/backend/commands/variable.c | 43
> ++++++++++++++++++++++---------------------
> 1 file changed, 22 insertions(+), 21 deletions(-)
>
>
I don’t think we need to add a separate function. We can use ‘if-else” to parse
log level, then verify it after “if-else”.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
