Hi, On 2025-12-11 15:43:36 +0100, Peter Eisentraut wrote: > On 10.12.25 01:45, Bryan Green wrote: > > The attached patch takes a pragmatic approach: for gettext 0.20.1+, we > > avoid triggering the bug by using Windows locale format instead of > > calling IsoLocaleName(). This works because gettext 0.20.1+ internally > > converts the Windows format back to POSIX for catalog lookups, whereas > > 0.19.8 and earlier need POSIX format directly. > > I can confirm that this patch fixes the performance deviation from > activating --enable-nls on Windows (tested with MSYS2/UCRT64).
FWIW, Bilal and I had, IIRC, explicitly not enabled on windows CI because it made the build process even slower. But perhaps we should re-measure the difference and re-consider? Greetings, Andres Freund
