Hi, > It's strange to see this thread go on about messing with the Perl script > because we're too afraid of pg_bsd_indent. Maybe we should take > ownership of that code -- improve its own indentation to our > conventions, add comments, rename unclear variables, and so on until we > have something we can work with, and fix these weird bugs and > idiosincratic behaviors we don't like. I just found out this code dates > back from 1976.
> With or without that nice-to-have, it'd be a lot of work with > not all that much payoff, so I'm finding it hard to recommend > that somebody go after this. But maybe someone will find it > irresistible to scratch that itch. I was thinking just recently that rewriting pgindent in Python might be a good idea for future refactoring, but probably only if and after we merge PyTest patchset [1]. (Which strangely enough is missing on the nearest open commitfest.) [1]: https://www.postgresql.org/message-id/flat/CAOYmi%2BkThkM9Z87u%3DR_Wi7fCor2i%2BUZKAyq0UCyprzCwTQvqgA%40mail.gmail.com -- Best regards, Aleksander Alekseev
