On Fri, Dec 12, 2025 at 1:25 PM jian he <[email protected]> wrote: > > On Mon, Dec 8, 2025 at 5:58 PM Amul Sul <[email protected]> wrote: >> [....] > > v5-0001: > AlterConstrEnforceabilityRecurse renamed to > AlterFKConstrEnforceabilityRecurse n > ATExecAlterConstrEnforceability renamed to ATExecAlterFKConstrEnforceability. > comments slightly adjusted, no other changes. >
Looks good to me, thanks ! > v5-0002: alter check constraint enforceability > The patch also looks good, but I have a minor comment for the test -- you created the check_constraint_status view, which is not dropped, it should be dropped at the end. Also, instead of a view, I think you could use the \set psql-meta-command; for example, see the init_range_parted or show_data tests in update.sql Also, run pgindent on both patches. Regards, Amul
