> On Dec 16, 2025, at 14:49, Bertrand Drouvot <[email protected]>
> wrote:
>
> Hi hackers,
>
> While working on relfilenode statistics, Andres suggested that we pass the
> Relation
> to pgstat_report_vacuum() (instead of the parameters inherited from the
> Relation,
> (See [1])).
>
> That looks like a good idea to me as it reduces the number of parameters and
> it's
> consistent with pgstat_report_analyze().
>
> PFA a patch to $SUBJECT.
>
> Thoughts?
>
> [1]:
> https://www.postgresql.org/message-id/ezbfcpjtfh3vtm667aegyrptcdsvinbuxw6y5p6j3e5fbffrl5@i7v6cjapz3yv
>
> Regards,
>
> --
> Bertrand Drouvot
> PostgreSQL Contributors Team
> RDS Open Source Databases
> Amazon Web Services: https://aws.amazon.com
> <v1-0001-Change-the-signature-of-pgstat_report_vacuum-so-t.patch>
Combing the two parameters into one looks clearer. And the function
pgstat_report_vacuum() has only 1 caller, the change is a small refactoring.
LGTM.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
