On Wed, Dec 17, 2025 at 11:57:13AM +0000, Bertrand Drouvot wrote: > Please note that for hash_bitmap_info() and pgstathashindex() the open calls > are > changed instead. For those we keep the IS_INDEX() checks to reject partitioned > indexes (which index_open() accepts via validate_relation_kind()). So, that > also > changes the error messages in some tests. If we do prefer the previous error > messages we could change the close calls instead (I prefer the way it's done > in the attached though).
I have noticed that the two surrounding relation_close() calls for the parent tables did not get the notice of the change for brin.c of what you are doing for the indexes, while we use table_open(). I have fixed these. It would be nicer if IS_INDEX() could be removed in the other code paths you are suggesting to change, but the partitioned index argument also means that we would have two code paths in charge of a relkind check instead of one. Just using relation_*() may be cleaner. -- Michael
signature.asc
Description: PGP signature
