On Fri, 19 Dec 2025 at 16:05, Fujii Masao <[email protected]> wrote: > > On Fri, Dec 19, 2025 at 7:07 PM Japin Li <[email protected]> wrote: > > Thanks for the patch — that was my oversight. > > > > LGTM with one small suggestion: > > Thanks for the review! > > > The comment says: "If the option is not found in connInfo, return NULL > > value." > > > > Since the parameter is named `keyword`, I'd suggest: "If the keyword is not > > found in connInfo, return NULL." > > > > This keeps terminology consistent with the function signature. > > I think "the option with the given keyword" is more precise than just > "the keyword". > That said, simply using "the option" also seems sufficient in this context... > > > Regarding 0002 patch, I found that it caused a CI failure, so I’ve updated > the patch to fix that. The revised patch is attached. > > Regards, > > -- > Fujii Masao
Hi! I checked the new TAP test 0002 changes. I am wondering, why are connection options validated so late in this test? I mean, we do ALTER PUBLICATION, then we restart publisher, wait for catchup, check alter publication, and etc, and only then we look if connection options are indeed applied? -- Best regards, Kirill Reshke
