Hi, On Tue, Dec 30, 2025 at 11:25 AM Chao Li <[email protected]> wrote: > > > > > On Dec 30, 2025, at 11:14, Álvaro Herrera <[email protected]> wrote: > > > > On 2025-Dec-27, Xuneng Zhou wrote: > > > >> On Fri, Dec 26, 2025 at 4:25 PM Chao Li <[email protected]> wrote: > > > >>> 2 - 0002 > >>> ``` > >>> + else > >>> + ereport(ERROR, > >>> + > >>> (errcode(ERRCODE_INVALID_PARAMETER_VALUE), > >>> + errmsg("unrecognized > >>> value for WAIT option \"%s\": \"%s\"", > >>> + "MODE", > >>> mode_str), > >>> ``` > >>> > >>> I wonder why don’t we directly put MODE into the error message? > >> > >> Yeah, putting MODE into the error message is cleaner. It's done in v8. > > > > The reason not to do that (and also put WAIT in a separate string) is so > > that the message is identicla to other messages and thus requires no > > separate translation, specifically > > errmsg("unrecognized value for %s option \"%s\": \"%s\"", ...) > > > > See commit 502e256f2262. Please use that form. > > > > To follow 502e256f2262, it should use “%s” for “WAIT” as well. I raised the > comment because I saw “WAIT” is the format strings, thus “MODE” can be there > as well. > > So, we should do a similar change like: > ``` > - errmsg("unrecognized value > for EXPLAIN option \"%s\": \"%s\"", > - opt->defname, > p), > + errmsg("unrecognized value > for %s option \"%s\": \"%s\"", > + "EXPLAIN", > opt->defname, p), > ``` >
Thanks for raising this and clarifying the rationale. I've made the modification per your input. -- Best, Xuneng
v11-0002-Add-MODE-option-to-WAIT-FOR-LSN-command.patch
Description: Binary data
v11-0001-Extend-xlogwait-infrastructure-with-write-and-fl.patch
Description: Binary data
v11-0003-Add-tab-completion-for-WAIT-FOR-LSN-MODE-option.patch
Description: Binary data
v11-0004-Use-WAIT-FOR-LSN-in-PostgreSQL-Test-Cluster-wait.patch
Description: Binary data
