Hello, On Mon, 10 Sep 2018, 19:33 Amit Kapila, <amit.kapil...@gmail.com> wrote:
> On Mon, Sep 10, 2018 at 1:12 PM Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > > > On Wed, Sep 5, 2018 at 2:04 PM Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > >> > > pg_stat_get_tuples_hot_updated and others: > > /* > > * Counter tuples_hot_updated stores number of hot updates for heap table > > * and the number of inplace updates for zheap table. > > */ > > if ((tabentry = pgstat_fetch_stat_tabentry(relid)) == NULL || > > RelationStorageIsZHeap(rel)) > > result = 0; > > else > > result = (int64) (tabentry->tuples_hot_updated); > > > > > > Is the special condition is needed? The values should be 0 because of > zheap right? > > > > I also think so. Beena/Mithun has worked on this part of the code, so > it is better if they also confirm once. > We have used the hot_updated counter to count the number of inplace updates for zheap to qvoid introducing a new counter. Though, technically, hot updates are 0 for zheap, the counter could hold non-zero value indicating the inplace updates. Thank you >
