> On 3 Jan 2026, at 00:16, Kirill Reshke <[email protected]> wrote:
> 
> PFA v4 with typo fixes.

Thanks!

I think block size dependency is not a problem. There are no pageinspect tests 
that pass with 1Kb pages.

I have some more nits:

Meson build needs to be updated.

Documentation is on a TODO list.

+ relation_close(indexRel, AccessShareLock);
Perhaps, index_close() is what you actually wanted?

StringInfoData buf is leaked still, you can init it once and reset in the loop.

tmpTupdesc recreation worth commenting on.


Thanks!


Best regards, Andrey Borodin.

Reply via email to