>On Wed, Jan 7, 2026 at 1:13 PM albert tan <[email protected]> wrote: >> I believe: >> 'will be searched' is better than 'will be search'. >> 'it assumes' is better than 'it assume'. > >Those are indeed grammatical errors. From a quick eyeball scan, this >file has other wording issues: > >/* > * Ignore already-found names. They are not reachable by the > * path search, so don't shown them. > */ > >"show" > >/* > * The directory parameter can be omitted, absolute, or relative to the > * installation's base directory, which can be the sharedir or a custom > * path that it was set extension_control_path. It depends where the > * .control file was found. > */ > >I imagine this means "or a custom path that was set via extension_control_path". > >/* > * Return a list of directories declared on extension_control_path GUC. > */
>I would guess this normally phrased something like "Return the list of >directories in extension_control_path". Hi Join, Thanks for pointing out extra issues. I have addressed them in v2. John Naylor <[email protected]> 于2026年1月7日周三 14:56写道： > On Wed, Jan 7, 2026 at 1:13 PM albert tan <[email protected]> wrote: > > I believe: > > 'will be searched' is better than 'will be search'. > > 'it assumes' is better than 'it assume'. > > Those are indeed grammatical errors. From a quick eyeball scan, this > file has other wording issues: > > /* > * Ignore already-found names. They are not reachable by the > * path search, so don't shown them. > */ > > "show" > > /* > * The directory parameter can be omitted, absolute, or relative to the > * installation's base directory, which can be the sharedir or a custom > * path that it was set extension_control_path. It depends where the > * .control file was found. > */ > > I imagine this means "or a custom path that was set via > extension_control_path". > > /* > * Return a list of directories declared on extension_control_path GUC. > */ > > I would guess this normally phrased something like "Return the list of > directories in extension_control_path". > > -- > John Naylor > Amazon Web Services >
v2-0001-Correct-comment-wording-in-extension.c.patch
Description: Binary data
