Some review comments for patch v21-0003. ======
(v21-0003 is identical to v20-0003. None of my v20-0003 review comments have been addressed yet.) ~~~ Anyway, here is one more review comment: 1. The DOCS for CREATE SUBSCRIPTION say: + <literal>pg_conflict</literal> schema. This allows for easy querying and + analysis of conflicts. This table is automatically dropped when the + subscription is removed. The DOCS for ALTER SUBSCRIPTION also say: + exist. Conversely, if the destination is changed to + <literal>log</literal>, logging to the table stops and the internal + table is automatically dropped. ~ I felt these topics about the CLT auto-removal need to be more prominent, like in a <caution> note or something similar, to recommend that the user must make a *backup* of the CLT first, if they intend to do post-mortem analysis of the conflict. Maybe the best place to put this <caution> is in the CREATE SUBSCRIPTION / Parameters / conflict_log_desttination = table section. IMO "post-mortem" implies first dropping the subscription (e.g. because it might be in some kind of apply retry-loop conflicting over and over and over), and then studying the logs/CLT to figure out where it went wrong. Therefore, it would be bad if the user wants to exactly that kind of study, only to find that they've accidentally also deleted all the CLT evidence when they dropped the subscription. ====== Kind Regards, Peter Smith. Fujitsu Australia
