On Fri, Jan 9, 2026 at 9:51 PM songjinzhou <[email protected]> wrote: > I tested the patch and have no functional questions. I have a small question: > Is it necessary to add "(also as a string, to support file_fdw options)" to > the final `ereport` error message in `defCheckCopyHeaderString`? Like in one > of your comments below.
Thank you for reviewing my patch and the comment! I don’t think we should add “(also as a string, to support file_fdw options)” to the ereport message because PostgreSQL error messages typically describe the semantic type rather than the input format. For instance, REJECT_LIMIT accepts a string in file_fdw but the error message simply asks for a numeric value. -- Best regards, Shinya Kato NTT OSS Center
