> On 15 Jan 2026, at 22:59, Kirill Reshke <[email protected]> wrote:
> 
> PFA v2 which leaves the test in-place.
> 
> Also commit message improvements.

Yeah, killtuples for GiST root page is broken. Your patch is fixing it.
I don't think we should backpatch this, the bug is harmless, but for master the 
patch LGTM.
It would be good to assign so->curBlkno and so->curBlkno together. But 
gistScanPage() is the only place with access to the block number.

+# Test gist, but with fewer rows - that killitems used to be buggy.

Probably, in this comment we can explicitly say that killitems was buggy, but 
now is fixed.

Thanks!


Best regards, Andrey Borodin.

Reply via email to