John Naylor <[email protected]> writes: > I don't think it's great to pass a NULL pointer to a sort, but the > length could conceivably be zero for future degenerate cases, so we > could silence the warning by adding "if (n < 2) return;" before the > for-loop. The advantage of doing that anyway is it allows us to remove > all four of the "if (d_ > ST_POINTER_STEP)" branches in the recursion > part. That's better for readability.
+1
regards, tom lane
