On Jan 21, 2026, at 04:07, Tom Lane <[email protected]> wrote: Chao Li <[email protected]> writes:
Enhancing the header comments also helps here. PSA v2: I had something more like the attached in mind. I'm not generally a fan of documenting only some of the arguments of a function, so I don't care for the way you handled the issue for other functions in tablecmds.c either. We can either assume that people read ATPrepCmd's comment and can extrapolate to the other functions, or we can do something similar to this for all of them. Got it, thanks. In v4, I’ve limited the changes to fully documenting all ATPrepCmd() arguments in its header comment and removed the scattered recurse/recursing references from other functions. I do agree with your 0002, but I see no point in pushing that separately. Absolutely. 0002 was too trivial to be a separate commit. I have squashed it into 0001 in v4. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
v4-0001-tablecmds-clarify-recurse-recursing-semantics-in-.patch
Description: Binary data
