From: Fujii Masao <[email protected]> Sent: Wednesday, January 21, 2026 15:38 To: Álvaro Herrera <[email protected]> Cc: Shinya Kato <[email protected]>; Chao Li <[email protected]>; PostgreSQL-development <[email protected]> Subject: Re: file_fdw: Support multi-line HEADER option.
On Wed, Jan 21, 2026 at 12:07 AM Álvaro Herrera <[email protected]> wrote: > > On 2026-Jan-20, Fujii Masao wrote: > > > I'm thinking to commit the attached patches. > > In 0001 I would recommend to move the string "match" to outside the > message. Otherwise a translator might be tempted to translate it, and > then it would make no sense. (I have never seen this happen in > Postgres, but I have seen this kind of translation mistake in other > software, and it is infuriating.) Thanks for the review! Agreed. I've updated the patches as suggested. The revised versions are attached. Regards, -- Fujii Masao ________________________________________ Hi Fujii-san, I've noticed an inconsistent naming convention in the patch: we use a capitalized Boolean for the boolean type, but a lowercase integer when referring to the value type. + errmsg("%s requires a Boolean value, an integer " + "value greater than or equal to zero Is there any reason why we follow this mixed style? Another nitpick in v6-0001 patch: tow whitespaces are between "special" and "value" + second %s is the special value "match" for that option */ Thanks, Steven
