On Wed, Jan 21, 2026 at 7:30 PM Chao Li <[email protected]> wrote: > > > > > On Jan 21, 2026, at 16:22, Peter Smith <[email protected]> wrote: > > > > On Wed, Jan 21, 2026 at 7:05 PM Chao Li <[email protected]> wrote: > >> > >> > >> > >>> On Jan 21, 2026, at 10:58, Peter Smith <[email protected]> wrote: > >>> > >>> A rebase was needed for some more test expected output changes. > >>> > >>> PSA v2. > >>> > >>> ====== > >>> Kind Regards, > >>> Peter Smith. > >>> Fujitsu Australia > >>> <v2-0002-Fix-to-make-psql-d-lists-of-inherits-look-same-as.patch><v2-0001-Fix-to-make-psql-d-lists-of-partitions-look-same-.patch> > >> > >> I still see some difference: > >> ``` > >> evantest=# \d+ p_test; > >> Partitioned table "public.p_test" > >> Column | Type | Collation | Nullable | Default | Storage | > >> Compression | Stats target | Description > >> ----------+---------+-----------+----------+---------+----------+-------------+--------------+------------- > >> id | integer | | | | plain | > >> | | > >> username | text | | | | extended | > >> | | > >> category | text | | | | extended | > >> | | > >> Partition key: LIST (category) > >> Indexes: > >> "idx_p_test_id" btree (id) > >> Partitions: > >> p_test_v1 FOR VALUES IN ('A') > >> p_test_v2 FOR VALUES IN ('B') > >> ``` > >> > >> The index name is quoted, but the partition names are not. > >> > > > > AFAICT > > Indexes are quoted > > Constraints are quoted > > Publications are also quoted > > > > Partitions are NOT quoted > > Inherits are NOT quoted > > > > ~ > > > > Please confirm --- So, you are expecting that Partitions and Child > > tables should also be quoted, so that everything looks the same? > > > > This is scope creep from the original intent of this thread, so I will > > look at doing this in a separate patch 0003. > > > > ====== > > Kind Regards > > Peter Smith. > > Fujitsu Australia > > Actually I don’t know the rule, which should be quoted and which should not. > Is the inconstancy a blocker? > > So, I was just pointing out the inconsistency, and I want to hear a > clarification from someone. >
OK. I feel that the "Partitions" and "Child tables" + "Interits" might be the odd ones out here, just as those were the odd ones out re the list indentation logic. But I will hold off on adding quotes for them until I hear some committer advice that it would be a worthwhile change. ====== Kind Regards, Peter Smith. Fujitsu Australia
