On Wednesday, January 21, 2026 10:46 PM Kuroda, Hayato/黒田 隼人 <[email protected]> wrote: > > I reproduced the issue by [1] and confirmed the issue was resolved by your > patch. Here are my comments. > > 1. > Replication slot cannot be invalidated even when only 0002 was applied. Can > you > modify the workload to cause invalidation without the fix? Or is it > impossible?
It's possible to cause invalidation if we avoid interrupting the test by removing the wait_for_log(), and I have done that in this version. > > 2. > It might be matter of taste, but I do not like substituting to the argument; > basically it's immutable. How about attached? It can indicate that minimum > safe > LSN would be used for the restart_lsn. > I think we can do that, but I would prefer to keep the current parameter name. So, I've opted to simply move the LSN comparison to the right of the slot.restart_lsn assignment. Best Regards, Hou zj
v2-0002-Add-a-tap-test-using-injection-point.patch
Description: v2-0002-Add-a-tap-test-using-injection-point.patch
v2-0001-Fix-race-conditions-causing-invalidation-of-newly.patch
Description: v2-0001-Fix-race-conditions-causing-invalidation-of-newly.patch
