Hi,
While reviewing the patch [1], I found that WalSndShutdown() calls abort()
with the comment "keep the compiler quiet" just after proc_exit(0).
static void
WalSndShutdown(void)
{
/*
* Reset whereToSendOutput to prevent ereport from attempting to send any
* more messages to the standby.
*/
if (whereToSendOutput == DestRemote)
whereToSendOutput = DestNone;
proc_exit(0);
abort(); /* keep the compiler quiet */
}
This may have been necessary in the past, but is it still required?
Other functions, such as CheckpointerMain(), simply call proc_exit(0)
without an abort(), which doesn't seem to cause compiler warnings.
That made me wonder whether the abort() in WalSndShutdown() is
still needed, or which compiler would actually warn if WalSndLoop()
does not end with an abort().
Thoughts?
[1] https://postgr.es/m/[email protected]
--
Fujii Masao
