Álvaro Herrera <[email protected]> wrote: > On 2026-Jan-23, Antonin Houska wrote: > > > > This way you wait repeatedly for one transaction until it is marked > > > committed; and once it does, you don't test it again. > > > > Sure, that's much beter. Thanks. > > Actually, I wonder if it would make sense to sleep just once after > testing all the transactions for whether they are marked committed (not > once per transaction); and after sleeping, we only test again those that > were not marked committed in the previous iteration. I think you would > end up doing less tests overall. Something like this
I suppose that TransactionIdDidCommit() returns false pretty rarely, so one iteration is sufficient in almost all cases. Besides that, I preferred simpler code because it's easier to test (It's not trivial to have debugger reach the conditions.) However it's just my preference - no real objections to your approach. -- Antonin Houska Web: https://www.cybertec-postgresql.com
