Hello, This is not an objection to this patch, but I don't see why we should allow newlines in tablespace names if we're going to restrict them in names of roles and databases. Is it only because pg_dumpall happens not to dump a comment with the tablespace name on it, like we do for dbs and roles? Sounds unprincipled.
I think keeping these things under the same rules makes the most sense. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "The problem with the facetime model is not just that it's demoralizing, but that the people pretending to work interrupt the ones actually working." -- Paul Graham, http://www.paulgraham.com/opensource.html
