Hi Peter, > I found that pg_dump.c has many pg_mallocs where the new object/array > macros could have been used, but currently they are not. I'm not sure > if this was a deliberate or accidental omission. > > In case it was accidental, here is a patch to modify/simplify all that > allocation code.
Thanks for the patch. I reviewed / tested it and it looks OK. This being said, I see many pieces of code left that still use pg_malloc / pg_realloc in a similar fashion, including src/bin/pg_dump/* files. Would you like to address those as well, or keep the scope only to pg_dump.c? -- Best regards, Aleksander Alekseev
