> On Feb 3, 2026, at 10:25, Kyotaro Horiguchi <[email protected]> wrote:
>
> Hello.
>
> At Tue, 3 Feb 2026 10:13:53 +0800, Chao Li <[email protected]> wrote in
>> The patch is straightforward and looks correct.
>
> Indeed, it does.
>
> However, the scoping of the define symbols in this file seems somewhat
> confused.
>
> For example:
>
>> static void
>> KillExistingArchiveStatus(void)
>> {
>> #define ARCHSTATDIR XLOGDIR "/archive_status"
>
> This define was presumably intended to be used only within the function,
> but since it is a macro, it can also be used from other functions, which
> appears to have contributed to this mistake.
>
> It would be better to clearly distinguish between file-scoped symbols
> and function-scoped ones. For function-local constants like this,
> using a 'static const char[] instead of a macro would make the
> intended scope explicit and help prevent similar issues.
>
Or we can just undef the macros before closing the functions.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
