Hi again Jim, Andrew! Thanks for another round on review, updated the patch according to comments.
Also, fix `make check` by updating pg_proc.data with new functions, similar to uuid7 way: defining _msg versions of the functions -- Best regards, Roman Khapov
v5-0001-message-in-pg_terminate_backend-and-pg_cancel_bac.patch
Description: Binary data
> On 3 Feb 2026, at 13:26, Andrey Borodin <[email protected]> wrote: > > > >> On 3 Feb 2026, at 12:52, Roman Khapov <[email protected]> wrote: >> >> <v4-0001-message-in-pg_terminate_backend-and-pg_cancel_bac.patch> > > Some notes on this version: > > 1. Did you mean BackendMsgShmemSize()? > size = add_size(size, BackendStatusShmemSize()); > > 2. In docs: > > <function>pg_cancel_backend</function> ( <parameter>pid</parameter> > <type>integer</type>, <parameter>message</parameter> <type>test</type> > <literal>DEFAULT</literal> <literal>''</literal> ) > > Did you mean <type>text</type>? > > 3. Windows build failed [0] > > 4. In src/include/utils/misc/backend_msg.c identification is backend_msg.h > > > Best regards, Andrey Borodin. > > [0] https://github.com/x4m/postgres_g/runs/62314358734
