On 2025-Feb-20, Daniel Gustafsson wrote: > > On 20 Feb 2025, at 14:06, Andrew Dunstan <[email protected]> wrote: > > > Actually, since ok() and friends return true iff the test succeeds, instead > > of > > + ok(! $self->{timeout}->is_expired, 'psql query_until did not time > > out'); > > + return undef if $self->{timeout}->is_expired; > > you can avoid doing the same test twice and say: > > ok(! $self->{timeout}->is_expired, 'psql query_until did not time > > out') || return undef; > > although for slightly technical reasons perlcritic disapproves of "return > > undef" and prefers that you just write a bare "return" so we should also > > fix that. > > Sorry for taking a second bite at the cherry. > > Not at all, I agree that this is an improvement so fixed in the attached along > with a fresh pgperltidy.
Hello, was this forgotten, or is there some other reason why the commitfest entry is still open? https://commitfest.postgresql.org/patch/4959/ Thanks, -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "La vida es para el que se aventura"
