Hi hackers,
This is my first patch
There is an incorrect assignment of nodeid = 0 in
TransactionIdGetCommitTsData() (commit_ts.c).
Elsewhere in the file, the code consistently uses InvalidReplOriginId.
Even though InvalidReplOriginId also evaluates to 0, it should be used
here for clarity and consistency.
Best regards,
Wang Peng
From 986f7499e63b1b4e97edb95ef98b0260fab3a9ff Mon Sep 17 00:00:00 2001
From: Wang Peng <[email protected]>
Date: Wed, 4 Feb 2026 21:47:44 -0500
Subject: [PATCH v1] Subject: Fix incorrect assignment for nodeid
TransactionIdGetCommitTsData()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
There is a incorrect assignment for nodeid.
Which should be ‘InvalidReplOriginId’ instead of ‘0’.
Author: Wang Peng <[email protected]>
---
src/backend/access/transam/commit_ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/access/transam/commit_ts.c
b/src/backend/access/transam/commit_ts.c
index 6fa2178..57ae04e 100644
--- a/src/backend/access/transam/commit_ts.c
+++ b/src/backend/access/transam/commit_ts.c
@@ -288,7 +288,7 @@ TransactionIdGetCommitTsData(TransactionId xid, TimestampTz
*ts,
/* frozen and bootstrap xids are always committed far in the
past */
*ts = 0;
if (nodeid)
- *nodeid = 0;
+ *nodeid = InvalidReplOriginId;
return false;
}
--
1.8.3.1