Re: Make wal_receiver_timeout configurable per subscription

[Fujii Masao]

On Thu, Feb 5, 2026 at 1:06 PM Japin Li <japi...@hotmail.com> wrote:
> Thanks for updating the patches.
> I have one small comment on v4-0002:

Thanks for the review!


> @@ -104,6 +105,7 @@ typedef struct SubOpts
>         int32           maxretention;
>         char       *origin;
>         XLogRecPtr      lsn;
> +       char       *wal_receiver_timeout;
>  } SubOpts;
>
> According to the comment above the SubOpts struct:
>
>         Structure to hold a bitmap representing the user-provided CREATE/ALTER
>         SUBSCRIPTION command options and the parsed/default values of each of 
> them.
>
> Since `wal_receiver_timeout` is a GUC-style interval value (typically stored 
> as
> integer milliseconds), wouldn't it be better to use an int32 here instead of a
> string?

The wal_receiver_timeout value in CREATE SUBSCRIPTION can include a unit
(for example, 10s), not just a plain integer. Because of that, we can't store it
in an int32, I think.

Regards,

-- 
Fujii Masao