> Eh, there are lots of examples of setting the default value in both the GUC > definition and the variable declaration. TBH I've always found excessive > macro use to hinder readability more than it helps anything.
One thing that would help is readability, as macros/constants usually have nice explanatory names. That could be improved by adding a "/* 7 days in seconds */" comment after the number, without a macro. But if somebody searches for the guc name, it's already defined as 7d elsewhere, so I'm not sure if this would be really useful. The patch looks good to me.
